DEV Community

Discussion on: Share your experience with feelings of embarrassment during code reviews

Collapse
 
bernardbaker profile image
Bernard Baker • Edited

I once forgot to squash my commits and was told my variable names were too descriptive. And that I didn't comment some code that a lead didn't understand because he'd never seen the JS code that allows you to monitor changes in HTML node attributes. A colleague called Olivia actually egged on some negative banter as I left the office. I didn't mind. I'm more mature than that.

I did feel embarrassed and her comments were wrong and out of place but I still don't mind.