Thanks for pointing out the error! I've fixed the bug.
Hewwo, pwease change
- if (hidden) { show(); } else { hide(); } + if (hidden) { hide(); } else { show(); }`.
if hidden is the current state. OR, if hidden is desired state, change
hidden
- if (!hidden) { show(); } else { hide(); } + if (!hidden) { hide(); } else { show(); }
You didn't flip the cases when negating the predicate.
Stylistically I would ofc prefer one of:
if (hidden) show() else hide()
or
hidden ? show() : hide()
for a better signal/noise ratio (which makes bugs more evident)
Apologies for the delay. I've fixed the logic error you rightly pointed out.
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Thanks for pointing out the error! I've fixed the bug.
Hewwo, pwease change
if
hiddenis the current state.OR, if
hiddenis desired state, changeYou didn't flip the cases when negating the predicate.
Stylistically I would ofc prefer one of:
or
for a better signal/noise ratio (which makes bugs more evident)
Apologies for the delay. I've fixed the logic error you rightly pointed out.