The latest articles on DEV Community by Daniel Tamai (@dtamai). https://dev.to/dtamai https://media2.dev.to/dynamic/image/width=90,height=90,fit=cover,gravity=auto,format=auto/https:%2F%2Fdev-to-uploads.s3.amazonaws.com%2Fuploads%2Fuser%2Fprofile_image%2F99253%2F445ac508-a80a-40b4-b7f3-8e06d4332970.jpeg https://dev.to/dtamai en Daniel Tamai Tue, 16 Apr 2019 02:00:10 +0000 https://dev.to/dtamai/hiring-process-should-i-review-some-candidate-s-code-looking-for-errors-or-potential-for-being-better-5d10 https://dev.to/dtamai/hiring-process-should-i-review-some-candidate-s-code-looking-for-errors-or-potential-for-being-better-5d10 <p>My experience is that it is much more common to look for errors when reviewing code submited by a candidate during the hiring process, things like:</p> <ul> <li>this class has too much responsibility</li> <li>that class does too little</li> <li>pattern X is not implemented correctly</li> <li>etc...</li> </ul> <p>My current company is like this, and after reviewing their code we invite the candidate to discuss it: we read/explain our comments and they defend their decisions. After the discussion I'm feeling really tired (the mood is more confrontation than collaboration,) and I'm not sure what kind of person does well in this kind of process.</p> <p>So I thought about it and realized that instead of looking for errors I could look for potential for making that code better, just like normal code review:</p> <ul> <li>this class has too much responsibility, what about extract this and that into another class?</li> <li>this class does too little, what about moving it into that other class?</li> <li>if you change this and that the code will implement pattern X</li> </ul> <p>On one hand this leads the candidate to an easy answer but on the other hand we know how they respond the a code review.</p> <p>Any thoughts/experience on reviewing code for hiring? </p> discuss