The latest articles on DEV Community by Irinabert (@irinabert). https://dev.to/irinabert https://media2.dev.to/dynamic/image/width=90,height=90,fit=cover,gravity=auto,format=auto/https:%2F%2Fdev-to-uploads.s3.amazonaws.com%2Fuploads%2Fuser%2Fprofile_image%2F1121963%2F6965fe59-0c97-4ca7-9f56-631e0486a5e0.jpeg https://dev.to/irinabert en Irinabert Wed, 19 Jul 2023 08:56:46 +0000 https://dev.to/irinabert/code-review-antipatterns-1cob https://dev.to/irinabert/code-review-antipatterns-1cob <p>Sarcastic advises for the vital process of software development. Because sometimes irony is the best teacher.</p> <h2> Be personal </h2> <p>Do you remember John didn't buy you a drink last time you met for a social? So reviewing his PR is the right time to show him how wrong he was. Challenge every idea, every possible variable name, and every white space in the PR. He deserves this.</p> <h2> Be excessive </h2> <p>That's right. Don't keep it. All thoughts, ideas, questions - put it all there. Just ask yourself, when was the last time you asked Anna how are her kids? Well, PR is the perfect place for it. What else can we add? Weather comments, photo of your pet, last update on your favourite football team. Let it be there.</p> <p><strong>formatting is our enemy</strong><br> we can save a lot of time ignoring all of the commas bullet point highlighting structure bolding markdown they are there to waist our time serve no purpose at all</p> <h2> Be unreasonable </h2> <p>"I just don't like it" is a perfectly valid reason for a PR rejection, because your word does matter.</p> <p><a href="https://media.dev.to/dynamic/image/width=800%2Cheight=%2Cfit=scale-down%2Cgravity=auto%2Cformat=auto/https%3A%2F%2Fdev-to-uploads.s3.amazonaws.com%2Fuploads%2Farticles%2Fxebk6j7t9wlxwjh35pef.gif" class="article-body-image-wrapper"><img src="https://media.dev.to/dynamic/image/width=800%2Cheight=%2Cfit=scale-down%2Cgravity=auto%2Cformat=auto/https%3A%2F%2Fdev-to-uploads.s3.amazonaws.com%2Fuploads%2Farticles%2Fxebk6j7t9wlxwjh35pef.gif" alt="Michael office I don't like it"></a></p> <h2> Be toxic </h2> <p>Try to put your colleague in their place with sarcastic comments in PR, answer the question with the question or use as many rare technical definitions and abbreviations as possible. They will scare, doubt themself, and lose confidence. That's the best way of learning.</p> <p><a href="https://media.dev.to/dynamic/image/width=800%2Cheight=%2Cfit=scale-down%2Cgravity=auto%2Cformat=auto/https%3A%2F%2Fdev-to-uploads.s3.amazonaws.com%2Fuploads%2Farticles%2Fu67bbz534fojqb7yqqvm.png" class="article-body-image-wrapper"><img src="https://media.dev.to/dynamic/image/width=800%2Cheight=%2Cfit=scale-down%2Cgravity=auto%2Cformat=auto/https%3A%2F%2Fdev-to-uploads.s3.amazonaws.com%2Fuploads%2Farticles%2Fu67bbz534fojqb7yqqvm.png" alt="Toxic comments"></a></p> <h2> Compare everyone with everyone </h2> <p>Don't forget to put a comment that Rachel did a similar task quicker, better and had no comments at her PR. You always have someone to compare to: Bill Gates, Mark Zuckerberg, Elon Mask, Linus Torvalds. You just need to find the right person for the situation.</p> <h2> Discuss PR privately </h2> <p>We are all friends here, right? So use personal chat to ask Jimmy to fix this line 78 in Program.py. No comments in PR, no bureaucracy, no problem. Plus, from the outside, Jimmy's PR will look perfect. Like there were no issues at all. It is a win-win situation ;)</p> <h2> Never resolve comments </h2> <p>If there are people that use comments in PR, teach them a lesson and never resolve them, so they can get lost in their comments and never finish PR.</p> <h2> Hints instead of explicit examples </h2> <p>Use PR as game time and leave some breadcrumbs and hints instead of explicit examples of what you meant so the PR owner can guess the right idea. You are there to help.</p> <p>P.S. Please add your antipatterns in the comments :)</p> codereview process sarcasm antitutorial