Patching Searchkich Gem To Add Custom Queries By Default

Mahmoud Sultan — Tue, 21 Jan 2020 18:42:31 +0000

Context

So a bit of context, as I'm working on Triplancer.net which is a Multi-Tenant Project developed by Ionite I needed to scope results returning for any Searchkick Query by the Current Tenant Id not to return results from other tenants.

You can do that simply by using a where query something like:

where: { tenant_id: current_tenant_id }

I did not want, however, to have to write this on every query I write, I wanted a way to override search method for models that are tenant-scoped, and add that tiny query by default to whatever Searchkick queries are made on that model.

Luckily, overriding stuff is fairly easy in Ruby, I just needed to look for where exactly should I inject my code.

SearchKick search() method

Looking at the Searchkick codebase for the source code of the method searchkick - that used to initialize searching inside a model - here: https://github.com/ankane/searchkick/blob/master/lib/searchkick/model.rb

You can find that, on line 43, Searchkick inserts a method called searchkick_search to the model eigenclass and conveniently to us alias this method with Searchkick.search_method_name which you can change but is set by default to search here: https://github.com/ankane/searchkick/blob/d10ffd4fd97003b638cb93821dcab3c86a2abba5/lib/searchkick.rb#L42

That makes our job very easy, all we need to do is follow the same convention and define a method, let's call it scope_searchkick, that has the same signature and currys the searchkick_search method with the scoping query.

  def self.scope_searchkick
    class_eval do
      class << self
        def search(term = '*', **options, &block)
          options[:where] = {} unless options.key?(:where)
          options_with_tenant_scope = options[:where].merge(
            { tenant_id: current_tenant_id }
          )

          searchkick_search(term, options_with_tenant_scope, &block)
        end
      end
    end
  end

Now, all we need to do is call this method after the searchkick method in our models.

I've defined this method in the ApplicationRecord class so that it'd be available in every model to call but you can define it anywhere you see suitable.

One last edit: Let's make it defensive and define it in a way that if we change Searchkick.search_method_name our patch would still work.

How to do that?, we can simply use define_method instead of def and pass the Searchkick.search_method_name now our scope_searchkick method is:

  def self.scope_searchkick
    class_eval do
      class << self
        define_method Searchkick.search_method_name do |term= '*', **options, &block|
          options[:where] = {} unless options.key?(:where)
          options_with_tenant_scope = options[:where].merge(
            { tenant_id: current_tenant_id }
          )

          searchkick_search(term, options_with_tenant_scope, &block)
        end
      end
    end
  end

You've got to love the Ruby Metaprogramming.

Vuetify TreeView Async Error (Cannot set property 'vnode' of undefined) Workaround

Mahmoud Sultan — Sat, 19 Oct 2019 14:08:04 +0000

Context

This is my first blog post here, so I wanted to keep it short and talk about a bug that I came across quite recently in Vuetify TreeView when using Async child loading.

This is, however, a workaround - for the people, like me, who need to push this now without opening a PR - and not a fix for the bug, so keep that in mind.

Recreating The Bug

Let's start with the code found on the vuetify component page found here: https://v15.vuetifyjs.com/en/components/treeview#async-items.

However, when I do push the children of the item, something like this happens:

TypeError: Cannot set property 'vnode' of undefined
    at a.register (VTreeview.js:257)
    at a.created (VTreeviewNode.js:132)
....

After a long session of debugging (not really I just open Chrome DevTools and set a breakpoint "at a.register (VTreeview.js:257)" and read the problem description on this StackOverflow here:

https://stackoverflow.com/questions/57293198/vuetify-treeview-error-loading-children-asynchronously/58396813#58396813

Vuetify basically tries to find a node in the nodes objects with key equal to the id of the child node, the child node, however, has no entry on this object hence the error.

Given the timeline I had and the need to push this ASAP:

My Just-Hack-it-For-Now Part of Brain: Then just create one.
Me: Aha.
My Just-Hack-it-For-Now Part of Brain: Yeah.

So that's exactly what I did.

in the fetchUsers function we can add a few lines for this before pushing the items the parent's children array.


const key = item.id
const parentNode = this.$refs.treeReference.nodes[key]

let childNode;
children.forEach((child) => {
  childNode = {...parentNode, item: child, vnode: null}
  this.$refs.treeReference.nodes[child.id] = childNode
})

First, let's get the ParentNode - which we are going to clone for the child - using the key item.id from nodes object in the tree.

Then for each child just clone the parentNode setting item to the child however and vnode to null.

This fixes it for me; code pushed and everyone is happy.

Please let me know if you have a less hacky solution for this, I'd really appreciate it.

DEV Community: Mahmoud Sultan

Patching Searchkich Gem To Add Custom Queries By Default

Context

SearchKick search() method

Vuetify TreeView Async Error (Cannot set property 'vnode' of undefined) Workaround

Context

Recreating The Bug