Pull request template

Anastasia — Sun, 29 Sep 2019 19:19:50 +0000

I am wondering how some people are against about a checklist of what a pull request should have before it can be merged / what a reviewer should be looking for when reviewing a PR.
Of course, all we are lazy humans. And we rather skip it at all than try to follow it up. But I think it's a problem of our attitude to this thing. Of course, this approach has own pros and cons. IMHO, the checklist reminds us about the important steps what we should do or check. It means better and more consistent code quality and helps to avoid breaking the rule of no surprises. Also, it's useful for new team members.
I am sure you will say, that a well-experienced developer should keep this list in mind all the time. But I am not talking about obvious things as use patterns, best practices: Single Responsibility Principle, KISS, DRY, SOLID, etc.

It could be something like that or even less:

Elvis operator ?:

Anastasia — Tue, 09 Jul 2019 21:04:30 +0000

I have started to learn Kotlin. And my lector told me about Elvis operator, but for me, it's a ternary operator. Oh... I didn't know about that, especially why people have kind of this association in their mind.

Do you know about that? Or have you faced such a situation?

DEV Community: Anastasia

Pull request template

Elvis operator ?: