Best Practice - Check if property exist and assign

Michael Lueckl — Tue, 07 Aug 2018 17:56:51 +0000

Hi all,

from time to time you might need to assign properties or similar to variables and in some cases some don't exist.

In PHP and most other languages it's pretty straightforward to check for example:

~~~~ php
if(isset($issue['samples']))
$i->samples = $issue['samples'];
~~~~

This is also ok for multiple cases:

~~~~ php
if(isset($issue['samples']))
$i->samples = $issue['samples'];

if(isset($issue['summary']))
$i->summary = $issue['summary'];

if(isset($issue['property_names']))
$i->property_names = $issue['property_names'];

if(isset($issue['description']))
$i->description = $issue['description'];

if(isset($issue['count']))
$i->count = $issue['count'];
~~~~

And at some point I came up with inline if's which makes it easier to write/read and maintain.

~~~~ php
$i->samples = (isset($issue['samples']) ? $issue['samples'] : null);
$i->summary = (isset($issue['summary']) ? $issue['summary'] : null);
$i->property_names = (isset($issue['property_names']) ? $issue['property_names'] : null);
$i->description = (isset($issue['description']) ? $issue['description'] : null);
$i->count = (isset($issue['count']) ? $issue['count'] : null);
~~~~

But I feel there might be other and better way's of handling this.

Here the full example with a foreach-loop:

~~~~ php
foreach($data['quality_issues']['data'] as $issue){
if($issue['property_names'] != 'product_category'){
print_r($issue);
$i = new QualityIssue();
$i->samples = (isset($issue['samples']) ? $issue['samples'] : null);
$i->summary = (isset($issue['summary']) ? $issue['summary'] : null);
$i->property_names = (isset($issue['property_names']) ? $issue['property_names'] : null);
$i->description = (isset($issue['description']) ? $issue['description'] : null);
$i->count = (isset($issue['count']) ? $issue['count'] : null);
$i->error = (isset($issue['error']) ? $issue['error'] : null);
$i->name = (isset($issue['name']) ? $issue['name'] : null);
$i->type = (isset($issue['type']) ? $issue['type'] : null);
$i->level = (isset($issue['level']) ? $issue['level'] : null);
$i->category = (isset($issue['category']) ? $issue['category'] : null);

    array_push($partner->catalog->quality_issues, $i);
}

}
~~~~

Maybe I'm overthinking this and the inline if is already the "perfect" solution (as if this exists :)) but I would like to hear from you how you normally handle this and if you came up with good practices that might help to improve this.

Cheers,
Michael

CONCLUSION:

Really appreciate the great feedback in the comments and wanted to describe the solution which I found most suitable suggested by @franco Traversaro:

~~~~ php
class QualityIssue{
public static function fromArray(array $source) : self
{
$i = new self();
foreach ($source as $property => $value) {
$i->{$property} = $value;
}

    return $i;
}

}

foreach($data['quality_issues']['data'] as $issue){
if($issue['property_names'] != 'product_category'){
array_push($partner->catalog->quality_issues, QualityIssue::fromArray($issue));
}
}
~~~~

Suggestion to improve dev.to user feed

Michael Lueckl — Thu, 12 Jul 2018 19:52:38 +0000

Hi all,

this is my first post and so far I was just playing silent reader, giving out hearts for great posts and saving the good stuff for late nights 😄
This portal is so great and I'm really happy to have found it!

Something that I noticed and that somewhat bothers me a bit is the User Feed, initially, I thought it's based on my tags but this is not the case.

Don't get me wrong, I love to explore new things but I think it would make more sense to have the Feed only show posts based on my followed tags so that I get all relevant posts based on my interests without distraction of other big topics, I'm looking at you "Web development".
Don't freak out web dev lovers 😛 but in my case, most of the time I'm not too interested in most web dev topics.
Because this is obviously very popular, my feed is always flooded with those posts.

What I have in mind would be, rename "Feed" >> "TOP"/"Top Posts" and have a new "Feed" based on the users followed tags.

It would even make sense to have cross-references of top posts based on tags, the user currently would not see in his feed.
It could show up like a "promoted" post in the user feed, something like "This could be interesting for you based on 'tag', 'tag'"

Not sure if this was ever considered or discussed, wasn't in the first search results, but I thought I bring it up as I feel this would be something not only I would appreciate.
Let me know if I didn't yet had have enough coffee and simply oversaw the option to set this up my self 😜

Thanks again for this great portal and of course for all the great people creating awesome posts!

Cheers,
Michael

DEV Community: Michael Lueckl

Best Practice - Check if property exist and assign

Suggestion to improve dev.to user feed