Adding my project to showcase. Is that a legit Hacktoberfest PR?

Cristopher — Thu, 01 Oct 2020 11:38:24 +0000

I've opened a PR that only adds my old side project to the showcase section of an open-source project. Will that count as a Hacktoberfest PR?

Here's the PR in question https://github.com/mathdroid/covid-19-api/pull/305

Help me understand how AWS Lambda reuses object

Cristopher — Thu, 23 Jan 2020 01:12:50 +0000

Good day to all of you,

I'm a complete newbie on AWS Lambda. Currently, I'm building an app which has an OO pattern with clean architecture on top of it for ease of testing on the handler function like so

async function setupBotHandler(): Promise<void> {
  const connection = await connectToDatabase();

  const serviceMap = new Map<string, BotService>();

  const announcementRepository = connection.getCustomRepository(
    AnnouncementRepositoryTypeORM,
  );
  const categoryRepository = connection.getCustomRepository(
    CategoryRepositoryTypeORM,
  );
  const stateRepository = connection.getCustomRepository(
    StateRepositoryTypeORM,
  );

  const announcementService = new BotAnnouncementService(
    announcementRepository,
    categoryRepository,
  );

  serviceMap.set(announcementService.identifier, announcementService);

  endpointHandler = new BotEndpointHandler(serviceMap, stateRepository);
}

export async function handler(
  event: APIGatewayEvent,
  context: Context,
): Promise<APIGatewayProxyResult | void> {
  if (!endpointHandler) {
    await setupBotHandler();
  }

  return await endpointHandler.handler(event, context);
}

My main concern is about reusing execution context. I've heard that lambda reuses any variables declared outside the handler functions if the container decides to reuse the execution context, which is why we must check if the object exist or not (from the if the statement in my case).

However, some tutorials on the net (example) doesn't seem to check if some variable which the handler function depends on already exist or not.

Should I stick to what I've done or should I do it like this:

const connection = await connectToDatabase();

const serviceMap = new Map<string, BotService>();

const announcementRepository = connection.getCustomRepository(
  AnnouncementRepositoryTypeORM,
);
const categoryRepository = connection.getCustomRepository(
  CategoryRepositoryTypeORM,
);
const stateRepository = connection.getCustomRepository(
  StateRepositoryTypeORM,
);

const announcementService = new BotAnnouncementService(
  announcementRepository,
  categoryRepository,
);

serviceMap.set(announcementService.identifier, announcementService);

const endpointHandler = new BotEndpointHandler(serviceMap, stateRepository);

export const handler = endpointHandler.handler;

Any explanation will be appreciated. Thank you!

DEV Community: Cristopher

Adding my project to showcase. Is that a legit Hacktoberfest PR?

Help me understand how AWS Lambda reuses object