DEV Community: Rob Seaver

Adopting the Angular Style Guide

Rob Seaver — Wed, 02 Oct 2019 23:03:58 +0000

I'm working on building some consensus on my team around coding standards. One thing that has sparked a bit of disagreement is coding conventions around Angular. One of our developers is very much in favor of adopting the Angular style guide for all of our Angular code while the other doesn't think it adds very much value. I'm looking for a compromise (mostly because I hate having conflicts).

The developer in favor of adopting the style guide believes that it is an essential part of code quality and that it enhances readability. The other developer cares very much about writing clean code but isn't as concerned about focusing on things such as sorting import statements. Both want to deliver great products and write good code but disagree on this point.

My feeling is that there is a vast array of extensions in the VS Code world (our editor of choice for frontend work) that can help us achieve a happy medium. What are your thoughts on adopting the Angular style guide as a team?

Moving to CI/CD

Rob Seaver — Mon, 09 Sep 2019 12:49:15 +0000

Last week I authored a quick post about moving my team towards CI/CD. I was looking for some feedback from folks, but I think as a neophyte to this community, I should have posted it with a "#help" tag to indicate more clearly that I was soliciting feedback.

To sum up, I'm getting some resistance in moving to CI/CD, and I was looking for feedback any of you who have made the transition. If you've faced resistance from your teammates, how did you help them get to a place where they felt more comfortable? For some more context, here's the original post: https://dev.to/rbseaver/continuous-integration-and-code-reviews-13bc

Thanks in advance for any advice!

Continuous Integration and Code Reviews

Rob Seaver — Fri, 06 Sep 2019 22:19:15 +0000

I'm working on moving my team to a continuous integration process. Right now, we do work in a feature branch and once the feature is complete, we submit it a pull request for code review/merging. However, I'm not a fan of introducing large features all at once, which requires someone to spend part of their day reviewing dozens (and sometimes 100+) changes in a single code review session. Small commits are ideal and make it much easier to identify problematic code, and it obviously lends itself to more frequent releases. I suspect I'm preaching to the choir here, so I'll avoid extolling the virtues of CI/CD.

Most of my team is on board, but one of our team members is a bit resistant to this change. I am completely empathetic to his position, however. His concern is that when we introduce many small commits over time, it becomes difficult to review the feature in its entirety to make sure the code is consistent and works with all of the previous pieces of code that were introduced. My position is that automated testing directly addresses his concern. It will become apparent pretty quickly if new code is incompatible with previous code, based on the automated test results. Bite-sized commits are much easier for a reviewer to digest, and allow the reviewer to focus on style, readability, etc..., instead of whether the code works properly.

Has anyone else transitioned to continuous integration and faced resistance along the way? How have you addressed it with your team? Thanks in advance for any input!

Please forgive any grammatical errors or lack of clarity. It is Friday afternoon and I'm struggling to put my thoughts together after a long week (and it's hard to want to think about work after you've gotten home) :)