re: Some advice to do a great code review VIEW POST

TOP OF THREAD FULL DISCUSSION
re: I totally agree with you but I see some advantages to use Pull Requests: I share my knowledge with all the team (not only my coworker who accepts...
 
  • Sharing knowledge is important indeed. Instead of github-prs I'd put it one a wiki, or post it on our internal (slack) forum, depending on what kind of knowledge it is. In my experience, comments in prs get lost at some point.
  • Verbal, direct communication shouldn't be avoided for the sake of keeping a track-record. Writing something down can help structure your thoughts and is of course a bit more permanent.
  • I can't imagine developing software without a CI pipeline. I am glad that's common-place now. Our CI includes compiling, unit-tests, integration-tests, build&deploy and complete end-to-end-tests.
code of conduct - report abuse