DEV Community

Discussion on: What was your win this week?

Collapse
 
jeremyf profile image
Jeremy Friesen

I closed out a Forem and DEV issue.

It looks like a small bit of work, but there were lots of tiny adjacent refactors that I also did as part of other pull requests. Those adjacent refactors helped make the issue resolution much easier.

  • Fixing Rubocop's auto-correct recommendations PR #16098 on (2022-01-13)
  • Replacing custom call with existing cached method PR #16083 on (2022-01-13)
  • Appeasing Rubocop as it sneaks some changes in PR #16085 on (2022-01-13)
  • Moving from 'should' syntax to 'expect' PR #16084 on (2022-01-13)
  • Adding a convenience/optimiization method. PR #16079 on (2022-01-12)
  • Refactoring to add helper method PR #16064 on (2022-01-12)
  • Moving the "Null" user object closer to User PR #16070 on (2022-01-12)
  • Extracting duplicate logic PR #16035 on (2022-01-10)
  • Removing unused Search::ArticleSerializer PR #16032 on (2022-01-10)
  • Favor using existing variable over re-parsing PR #15995 on (2022-01-10)
Collapse
 
andypiper profile image
Andy Piper

That's a fair number of small things to wrangle - nice work (and thank you!)

Collapse
 
jeremyf profile image
Jeremy Friesen

It was a great learning experience. I have a much deeper understanding for the interplay of JS and Rails.

Collapse
 
felipeazucares profile image
Phil Suggars

Nice work! And thank you.

Collapse
 
graciegregory profile image
Gracie Gregory (she/her)

👏