Thanks for your criticisms, I'll definitely take them into account. I agree with you that some of the loops aren't the most meaningful, and I'll clean that up (the i/j naming for the index in the loops is a habit I've carried over from Java where it's idiomatic).
I'll also make sure to check out that more optimal algorithm.
Thanks for your criticisms, I'll definitely take them into account. I agree with you that some of the loops aren't the most meaningful, and I'll clean that up (the i/j naming for the index in the loops is a habit I've carried over from Java where it's idiomatic).
I'll also make sure to check out that more optimal algorithm.
Glad I could help, I love doing Go reviews, it helps me become a better dev.
Whenever you need a PR review just ping me, I'm a rookie to but I'll try my best.
PS: you can use the #reviews channel from the Gopher slack server too