loading...

re: Introducing textua11y: A Color Contrast Tool VIEW POST

FULL DISCUSSION
 

It also doubles as a color scheme picker for a blog! Will start working on it.

EDIT: That CSS isn't really responsive, borders go bonkers and appear in wrong place with wrong size when the window is resized, and it's impossible to use it correctly on a phone. Working on curing it with some CSS Grid! :D

VS Code and Firefox side-by-side

EDIT 2: To-Do list:

  • palettes! :D
  • CSS variables export
  • responsive design
  • making the code nicer!

EDIT 3: when I said "making the code nicer" I meant that I want to organize the elements because they are scattered around, and that doesn't work well for SEO. Also I want to remove the <hr/> element and replace it with CSS borders, and make the website more accessible.

 

"Yuck", "it's not good". DEV is a welcoming and constructive place. Please edit your comment accordingly.

 

oh, okay. edited the comment to make it more constructive.

Thank you. Might I also ask why you forked the repo? To my understanding, the post was asking for recommendations for features for the OP to add. Not for a code review.

To add my own features that I want. If OP doesn't want my changes in her repository, then I will rename the project, while keeping OP's copyrights and adding my own copyrights for my changes.

What about this thread makes you think I’d want to collaborate? You immediately insulted all of my code and now you’re essentially saying you want to steal my project.

  1. I didn't insult all of your code. I just pointed out some issues with it (like the impossibility of website's usage with a phone, scattered HTML elements). Those aren't really hard to fix. Your code is actually good. I apologize for my very inappropriate words against your code.
  2. I'm not going to steal your code. I'm just going to make my own, modified version of your project, and say "YadaYadaYada is a modified version of textua11y, which was developed by Ashlee Boyer". Now I deleted the code off my computer altogether.

Thank you for apologizing. If you have Twitter, send me a DM and we can talk a little bit more about this situation. I don’t want to discourage you from code at all. Conlin made some great points in his comment and as he said, this is a good learning experience.

Sadly, I have Twitter, but I can't DM you (Twitter doesn't show me a DM button). I can make an issue in your GitHub repository, and we could discuss the ideas that I proposed there.

 

Yeah, that's definitely not the way to approach this. It looks like you are fairly young and new to this game, so let me give you some advice around constructive criticism, good open source contribution, and making good technical decisions.

First: As Laurie pointed out, comments like "yuck" don't further any discussion. They do the exact opposite. Instead of making people want to work with you, it makes people shut down and not take any of your comments to heart. Instead, try leading with some positive comments - "this is really cool" or "I really like this idea!". Then make sure your feedback is what the person is actually asking for. In this case, Ashlee was asking for feedback on what things people would like to see. You instead took it upon yourself to make those contributions. Ashlee posted her work on Github and you definitely should be empowered to suggest changes, but you need to do so in a constructive way.

That brings us to the next point. Contributing to an open source project is a privileged granted to you by the maintainer of that project. Now, Ashlee hasn't placed a license on the repo and you are within your rights to fork said repo. But a certain amount of respect should be had for the owner. Open source work is like a garden - we all have to tend to it well to make sure it continues growing. If we all try to plant our own plants wherever we want, nothing has good growth potential. A good option here might have been to make a constructive, positive issue on the repo, outlining some possible features you would like to see. Then a comment along the lines of "I'd love to help with this! I'll start on a PR to add X feature" would be a great option to get involved.

This brings me to my next point - not all the features you think are the right ones are actually the right ones. This app doesn't need CSS grid. The layout collapses on mobile, but that could be fixed with about 2 lines of code. You aren't "curing" anything with your code - you aren't a doctor and your code isn't the magical cure to the woes of Ashlee's project. The project loads at most sizes and there is a good argument to be made that it has no reason to be loaded on a mobile device. That's definitely not a feature I would prioritize off the bat.

Your other ideas are good - palettes would be nice and a way to get the CSS variables is great, but your presentation leaves a lot to be desired. "Making the code nicer" isn't a feature, it's a personal preference. And the app doesn't really need SEO - it might be nice, but the Github page will do a good amount of that work. Using CSS borders might be nice, but isn't 100% needed - hr's are fine.

I don't want to drive you away from contributing to this - you have good thoughts and I'm sure you are enthusiastic about working on this project, but your presentation could use some work. If I were you, I'd make an apology for coming off offensive and then rework your comment to be constructive. This is a great learning opportunity moving forward! You have a good way to go in your career and this is a moment you should look back on as growth as an individual.

 

You definitely have a good point. I'm certainly not the most positive person. And when it comes to explaining/commenting on something, I'm actually quite awful. I often have controversies IRL, so I definitely need to work not only on my presentation, but also on my attitude.

It's ok - it can be hard to do. Positivity is a skill as is constructive criticism! You can work on both of those things! If you are less comfortable doing it IRL, online is a great place to learn and grow. One other piece of advice I have is to approach everything from the standpoint of trying to learn. If your explanation is along the lines of "Here is what I am thinking on this, what do you think?" you are leaving room in the conversation for the other person. If you can do that, you'll be golden. Feel free to reach out to me anytime if you are looking for feedback. I'd be happy to help you out!

Also, no one's code is perfect. For example, I can't say that my code is perfect. Everyone's code has some flaws, like everything in the universe.

Right - that means that you need to approach everything from a standpoint of thinking about people. Code is way more people-centric than it is machine-centric. There isn't ever a "right" answer, so approaching it from trying to learn, not trying to be correct.

code of conduct - report abuse