DEV Community

Discussion on: A pull request is submitted, what next?

Collapse
 
mortoray profile image
edA‑qa mort‑ora‑y

When it comes to trivial details, or minor things, I find it best to just give in an make the changes a reviewer has requested. If it's trivial then the change should be fast and not matter. This saves a lot of wasted time.

It also builds goodwill with the reviewer. This is important since it means when you do argue a point they are more willing to accept your position. If you just argue everything then it creates a more contentious atmosphere.