DEV Community

loading...

Discussion on: Edge, an OpenSource NextJS application with dynamic API for makers and developers.

Collapse
rafinskipg profile image
Rafael Pedrola Gimeno Author

you are totally right, we may rewrite it with typescript if the community likes it. I am not used to using typescript in my day to day, that's why I didn't use it at the beginning, but maybe is time

Collapse
muni profile image
Muni Perez

I see.

I have a lot of experience with TS and would be happy to contribute if you are interested.

Thread Thread
rafinskipg profile image
Rafael Pedrola Gimeno Author • Edited

Thanks muni, i will start a branch on the following days to introduce TS and will leave some notification here. I would like to start introducing it gently (not typing everything but the most important parts)

Thread Thread
muni profile image
Muni Perez

Great! Please let me know ;)

Thread Thread
rafinskipg profile image
Rafael Pedrola Gimeno Author

Hello @muni, this is the branch ts if you want to contribute.
github.com/nucleo-org/edge-next/tr...

I already introduced some typing. Some notes: make PRs to the ts branch, make small changes so we can evaluate if the approach is good. Since we don't want to fully migrate yet to TS until we are sure we are following the best practices

Thread Thread
muni profile image
Muni Perez

Great. Will work on it tonight.

Thread Thread
muni profile image
Muni Perez • Edited

@rafinskipg , can you add me as a contributor to the repo? My Github user is muniperez

Thread Thread
rafinskipg profile image
Rafael Pedrola Gimeno Author

I think you can do a pull request by forking the repository, right? without having the contributor permissions. let me know, please

Thread Thread
muni profile image
Muni Perez

Yep worked. Thanks!