DEV Community

Discussion on: My opinion on what makes a good Code Review.

Collapse
 
simeg profile image
Simon Egersand 🎈

Good points! I prefer giving concrete examples about names rather than use terms like "more descriptive". What's descriptive is subjective and I've been in situations where the PR author doesn't know what to change it to.

Tests is one thing I keep an eye out for. If there are none I don't approve it unless for good reasons 🙂