DEV Community

Discussion on: I've made a react component that hides sensitive information in your app.

Collapse
 
aminmansuri profile image
hidden_dude

Hmm then it's not really secure or "safe".
It's just activating and deactivating.

Thread Thread
 
robbiegm profile image
RobbieGM

What did you think the point of it was?

Thread Thread
 
aminmansuri profile image
hidden_dude

I don't know.. but "safe" doesn't seem like the right word to use here.

Thread Thread
 
christiankozalla profile image
Christian Kozalla

When I read the title of the post, "sensitive information" makes me think of API secrets..

If I want to hide something visually, I can provide a global CSS ID for the same purpose myself...

Thread Thread
 
grantdotdev profile image
Grant Riordan

My thought exactly , I'd rather have a component which perhaps encrypts the data or redacts it on toggle or component render.

Thread Thread
 
aminmansuri profile image
hidden_dude

yeah.. i was thinking something similar.

Thread Thread
 
itaylisaey profile image
ItayLisaey

Sorry about that, didn't mean to mislead anyone.
I think I clearly state in the library that it is only for visual purposes it is NOT secure in anyway by design.

Thread Thread
 
aminmansuri profile image
hidden_dude

Of course not. I just suggest you change the name to "activate" or "hide" rather than "safe". Because "safe" gives the impression of being a security feature.

But good work and kudos for your efforts.