DEV Community

Discussion on: How do you review CSS?

Collapse
 
antonfrattaroli profile image
Anton Frattaroli

Off the top of my head, these are the sorts of things that would cross my mind when reviewing a PR for a UI framework:

  1. Did they use BEM correctly?
  2. Did they apply theming correctly?
  3. Is there duplicate CSS?
  4. Is there unnecessary CSS?
  5. Did they use non-class selectors?
  6. Did they hardcode colors?
  7. If they modified the CSS, did they update the screenshots?
  8. Are the scss variables documented and marked as default if necessary?
  9. Are the rules in the correct order?
  10. Are animations able to be disabled?

Those are the only ones I can think of that are actionable. "Does it feel right?" doesn't really count, but it would be on my list.