Discussion on: Hacktoberfest Completion Thread

[Chris Bongers]

I did it so far!
3 PRs merges and really challenged to even do more :D

Just learned so much from people's feedback on the PRs and refactoring that.
Also felt like I needed to document better which pushed me.

My four contributions:

Added random boolean example script #21

rebelchris posted on Oct 01, 2020

Added boolean example page, also see this screenshot to see my tests.

This will solve issue #4

View on GitHub

Fix mobile issue #90

rebelchris posted on Oct 01, 2020

Issue that this pull request solves

Closes: #74

Proposed changes

Changed the footer to be center-aligned on Mobile. Added an alt text for the logo. Wrapped the logo in a P tag for space on mobile.

Types of changes

Put an x in the boxes that apply

• [ ] Bugfix (non-breaking change which fixes an issue)
• [ x ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Documentation update (Documentation content changed)
• [ ] Other (please describe):

Checklist

Put an x in the boxes that apply

• [ x ] My code follows the style guidelines of this project
• [ x ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ x ] My changes generate no new warnings
• [ x ] My changes does not break the current system and it passes all the current test cases.

Screenshots

Other information

Any other information that is important to this pull request

View on GitHub

Feature/multi tag #9

rebelchris posted on Oct 02, 2020

Fix issue #6 regarding the filters. You can now filter on multiple queries.

Please note: GitHub graph API does not like the "AND" filter, so included a custom filter (made a manual loop for speed)

You can see the result in the attached screenshot. It also still works for 1 query

View on GitHub

Added random date + options and documentation #28

rebelchris posted on Oct 02, 2020

Hi,

Created the randomDate function which has the following formats:

• min
• max
• format
• range

Also added a documentation example that showcases different variants. Solves issue #26

View on GitHub

[Roberto B.]

Hey @dailydevtips1 !
Thank you for your PR on rando-php project.
Your PR was high quality contributions (implementation, tests, documentation, examples).
I love hacktoberfest because we have the opportunity to meet people like you, improve the quality of the code, adding features, and learn a lot from each other!

Thank you!
Roberto

[Chris Bongers]

Indeed thank you for the opportunity I learned so much from that PR in terms of coding quality and documenting.
Also first touch on phpunit so very happy ✌️👌