Well written! There's one thing I disagree: Why wait until a PR is submitted to perform a code review? I find myself asking for feedback and performing reviews myself even before a commit is made, and it leads to much less friction. Besides, it is easier to correct the course when you do it earlier.
Discussing architecture in the team before developing might be helpful to reduce later review communication.
Asking a colleague while developing (before submitting a PR) might be helpful.
And I actually often adopt such approaches.
BTW, I didn't intend to write that we have to wait for review until submitting a PR
If there are unclear descriptions that cause misunderstanding in the article, please point them out, I want to improve!
In my teams we often use such approach - person puts code on review before covering it with tests. This way we minimize a possible wasted effort.
However, of course for complex tasks a selected approach should be discussed with team members before diving deep into a coding.
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Well written! There's one thing I disagree: Why wait until a PR is submitted to perform a code review? I find myself asking for feedback and performing reviews myself even before a commit is made, and it leads to much less friction. Besides, it is easier to correct the course when you do it earlier.
What are your thoughts?
Thank you for your opinion, I agree with you!
For example:
And I actually often adopt such approaches.
BTW, I didn't intend to write that we have to wait for review until submitting a PR
If there are unclear descriptions that cause misunderstanding in the article, please point them out, I want to improve!
In my teams we often use such approach - person puts code on review before covering it with tests. This way we minimize a possible wasted effort.
However, of course for complex tasks a selected approach should be discussed with team members before diving deep into a coding.