DEV Community

loading...

Discussion on: Creating an opinionated GraphQL server with Go - Part 1

Collapse
mike1808 profile image
Michael Manukyan

Hi, I appreciate the effort of creating this, but it contains quite many errors and if some beginner tries to follow these steps she will be blocked by them.

  1. In the step 2) the pathGQL variable is not defined
  2. You're creating file pkg/srv/main.go but then referring to pkg/server
  3. In the last step you should refer to cmd/server/main.go but you referre to cmd/gql-server/main.go.
Collapse
cmelgarejo profile image
Christian Melgarejo Bresanovich Author

Hi Michael, thanks for replying!

On points 1 and 2, you're right, good catches, I've fixed that missing variable and typo now.

I saw what you meant, on point 3, pointing to the right file right now.

Let me tell you that I've marked the post for advanced programmers for that reason, we all can err != nil from time to time and that's why I'm sharing, and that helps all us improve.

Collapse
mike1808 profile image
Michael Manukyan

So what was the point of changing that file to that one-liner if you then modifying it to the initial code with small changes?

Thread Thread
cmelgarejo profile image
Christian Melgarejo Bresanovich Author

Sorry, which one liner?
EDIT: Now should be pointing to the right file, everything should make sense now.

Thread Thread
mike1808 profile image
Michael Manukyan

So, we created this file cmd/gql-server/main.go, then we are moving that files logic to pkg/server/main.go and calling the exposed Run() function. Afterwards we add this utility which helps to read from .env file. However, we then are using these utility functions back in cmd/gql-server/main.go where we have Server.run(). I suppose we need to modify the file in pkg folder.

Am I missing something? I'm just trying to follow the guide.

Sorry if my initial comment sounded rude, didn't intend to that.

Thread Thread
cmelgarejo profile image
Christian Melgarejo Bresanovich Author

Yes you were correct, I've modified the source according your observations, thank you Michael!