Discussion on: No to Imperative Code! Because Debugging Spaghetti is No Fun

View post

Replies for: good names are clean and declarative. bad names are not imperative, they are just bad Code Smell 33 - Abbre...

Yes, but the way you’re using the terms “declarative and imperative” is not aligned with the computer science definitions of those words.

Imperative code tells the computer to do something. “Reduce over this list of orders by summing their cost”

Declarative states an axiom or truth. “This value is the result of applying a fold right operation using the function a on x”

you are right.
I am abusing the concept.
It is declarative code with bad names

I don't agree because it should never be set on stone.

"Max" is pretty descriptive even if you don't use "maximum", inside that scope it's ok. Wouldn't be true if "m" were used.

However, in this example:

const productsIds = products.map(p => p.id)

I would say one letter is the correct choice, since:

const productsIds = products.map(product => product.id)

Having no abbreviations actually hurt how to read and generate just extra clutter.

My rule of thumb is to have the name length inversely proportional to the scope.

A dozens of lines function calls for bigger, descriptive names.
A one liner? Maybe one letter is enough.

'My rule of thumb is to have the name length inversely proportional to the scope'

It is fine.