DEV Community

loading...

Discussion on: Your very first responsive and animated navigation bar with React and React-Spring

Collapse
nunocpnp profile image
Nuno Pereira Author

This is a standard way of use Styled Components in React but thanks for your comment. If you dont link to use it this way you can put the styled component on another file

Collapse
matthill8286 profile image
matthill8286

My comment was purely about your javascript. The code you have given us as an example would fail when run through eslint.

Please be careful sharing code that is bad practice as you are encouraging others to write code in this way.

Thread Thread
nunocpnp profile image
Nuno Pereira Author

I understand what you are trying to say but, is not true.

You will not get any linting error, if you quickly install eslint and extend airbnb preset or even react-standard for instance on my demo you will see that no error or warning will show up.

Declaring styled-components in react at the end of the file is not consider bad practice either.