DEV Community

Discussion on: I Got a Perfect Lighthouse Score on My First Portfolio Website!

Collapse
 
selion05 profile image
Selion05

Just some things I noticed.

  • /about: The footer isn't at the bottom.
  • colors: Hard to read, kind of painful. I don't like black for a dark theme, use dark grays!
  • light theme: Think about readability, people will want to read on you page in the sun or shiny rooms as well and then light theme >> dark theme.

besides that, 👍!

Collapse
 
prnvbirajdar profile image
Pranav Birajdar

Sorry, I did not understand the first remark.
Dark grays, got it!
Yeah, I am in process of adding a light theme. Many folks suggested that.

Collapse
 
selion05 profile image
Selion05

On pranav-birajdar.vercel.app/about

I have still black space below your footer because the content is not long enough.
Have a look at e.g. css-tricks.com/couple-takes-sticky...

Thread Thread
 
prnvbirajdar profile image
Pranav Birajdar

Thanks! I got what you're saying. I'll get on it!