re: Good Practices - Code Review Comments VIEW POST

FULL DISCUSSION
 

Hey Gabriel, great article. I'm curious about the following statement:

Code submitted for PR should be tested by another developer before you open a PR

How do you do that in practice?

 

Hey Sten, bit of a typo on my part, it should read "Code submitted as a PR should be tested by another developer before it's merged"

I'll update the article.

 

Ah thanks, I thought you were doing some Gerrit-style magic 😅

I've used phabricator in the past to do "non pr" diffs...but yeah, in this case just a typo!

code of conduct - report abuse