DEV Community

Discussion on: Good Practices - Code Review Comments

Collapse
 
stenpittet profile image
Sten

Hey Gabriel, great article. I'm curious about the following statement:

Code submitted for PR should be tested by another developer before you open a PR

How do you do that in practice?

Collapse
 
gabeguz profile image
Gabriel Guzman

Hey Sten, bit of a typo on my part, it should read "Code submitted as a PR should be tested by another developer before it's merged"

I'll update the article.

Collapse
 
stenpittet profile image
Sten

Ah thanks, I thought you were doing some Gerrit-style magic 😅

Thread Thread
 
gabeguz profile image
Gabriel Guzman

I've used phabricator in the past to do "non pr" diffs...but yeah, in this case just a typo!