DEV Community

Discussion on: Implementing an Invoice Numbering System with PHP using Laravel 6

View post
Collapse
 
stetim94 profile image
stetim94 •

FormRequest is a child class of Request, so doing this:

    $prefix = request()->prefix;
    $numberSequence = request()->number_sequence;
Enter fullscreen mode Exit fullscreen mode

feels like an anti-pattern, you rely on the container to give you the current request, while in a child class of request. you can simply do:

    $prefix = $this->prefix;
    $numberSequence = $this->number_sequence;
Enter fullscreen mode Exit fullscreen mode

or even use any method available in request class:

    $prefix = $this->input('prefix');
    $numberSequence = $this->input('number_sequence');
Enter fullscreen mode Exit fullscreen mode
Collapse
 
mirmayne profile image
Daveyon Mayne 😻 •

Awesome! Thanks for that!