DEV Community

Discussion on: Your website sucks! And I'll tell you why (ROUND 2) ⚑️⚑️

Collapse
 
toktoktwan profile image
Twan Mulder

Thanks for sharing Franco!
Starting off, your website looks amazing πŸ˜„

2 small things I noticed:

1. On a larger screen, the user is able to scroll just a TINY bit

Something about the CSS is causing the home and contact page to be larger than they need to be.

2. External links don't open in a new tab/window

For external links, I'd advise making them open in a new tab.
This way, a user can easily go back to your own webpage.
Be sure to use rel="noopener noreferrer"

Collapse
 
francoscarpa profile image
Franco Scarpa

I was aware of the height issue, but it’s OK for me; I also decided for myself to open links in the same window. Thanks anyway!

Thread Thread
 
apotheon profile image
Chad Perrin

Thanks for keeping links working the way they were intended. Opening in a new tab/window is easily accomplished with a middle click, but forcing something to open in the same tab/window when a site has decided to force things to open in new tabs/windows is not so straightforward.

There are occasions where opening a link in a new tab/window is a good idea but, when in doubt, leave it out. Give the user choice based on standard approaches.

Thread Thread
 
francoscarpa profile image
Franco Scarpa

Sorry, but I didn’t understand your point of view... Can you explain it better?

Thread Thread
 
apotheon profile image
Chad Perrin

I'm just saying that links that work the default way -- opening in the same browser tab/window normally, but in a new tab/window when someone middle-clicks -- are usually a good idea. It seems that is how your website works, and I think that's a good thing, even if Twan Mulder thinks you should change it.

Thread Thread
 
francoscarpa profile image
Franco Scarpa

Thanks. I decided to follow your advice: now the links open in a new tab 😊