DEV Community

Discussion on: Do you double check your PR’s?

Collapse
 
utkarsh profile image
Utkarsh Talwar

That looks like a good checklist to go through before submitting a PR. We actually had a healthy discussion yesterday about what constitutes a "good" PR, as we're updating our company best practices for the same. One of them is that for new features, adding a GIF of the working feature is mandatory wherever applicable.

Collapse
 
clara profile image
Clara

I love the ideas of GIFS - when I was at the beginning of my career I was terrified to submit PRs, I guess that would have lighten my mood a little bit.