DEV Community

Discussion on: The Art of Humanizing Pull Requests (PR’s)

Collapse
 
yellowbrickcode profile image
Sarah Williams

Love the nitpick idea. I always clarify with something like “not a big deal but” so I’m definitely going to start prefixing with nit instead of doing that.

Collapse
 
rysilva profile image
Ryan Silva

Only thing is I've had people say "nit" to me on things that were pretty subjective (like it deviated from their preferred style but was in no way a standard for our team). In those cases using "nit" almost seems insulting, like they've assumed that their suggestion is correct. I think "nit" is fine when it's something obvious (like extra whitespace or a typo).

Collapse
 
kulkarniankita9 profile image
Ankita Kulkarni • Edited

Yeah, that's awesome that you loved it. nitpicks are minor but technically relevant. I love them. It removes the awkwardness of being picky (sometimes) 😅

Collapse
 
jvarness profile image
Jake Varness

Someone wrote "nit" in a code review at my company once, and someone who wasn't familiar with that term thought that was the preferred name of the author 😂

Thread Thread
 
kulkarniankita9 profile image
Ankita Kulkarni • Edited

Haha this is hilarious. I was going to suggest that we should share some common practices with new devs or new clients although we wouldn't get to giggle on this one then 😁

Collapse
 
karfau profile image
Christian Bewernitz

We are using prefixes for close to every comment:

Minor: means the commitees can chose whether to improve that one
Major: this one needs to be adressed
Question:...

works quite well for us