DEV Community

Discussion on: Rebuilding Promise.all()

Collapse
drewclem profile image
Drew Clements Author

Beautiful!!

Collapse
lionelrowe profile image
lionel-rowe

Can be made a little more elegant at the cost of a little performance like this:

const isDense = arr => arr.length === Object.keys(arr).length
// ...
if (isDense(values)) {
    resolve(values)
}
Enter fullscreen mode Exit fullscreen mode

That way we can get rid of the resolvedCount variable.

But I think @darkwiiplayer 's second solution is by far the most elegant 😉