Bugfixed version:
Spoiler We write directly to indexes in the array, instead of pushing, and keep track of the resolved count in a separate variable. const promiseAll = promises => { return new Promise((resolve, reject) => { const values = new Array(promises.length) let resolvedCount = 0 for (const [index, promise] of promises.entries()) { promise.then(value => { values[index] = value if (++resolvedCount === promises.length) { resolve(values) } }).catch(err => reject(err)) } }) } Enter fullscreen mode Exit fullscreen mode
We write directly to indexes in the array, instead of pushing, and keep track of the resolved count in a separate variable.
push
const promiseAll = promises => { return new Promise((resolve, reject) => { const values = new Array(promises.length) let resolvedCount = 0 for (const [index, promise] of promises.entries()) { promise.then(value => { values[index] = value if (++resolvedCount === promises.length) { resolve(values) } }).catch(err => reject(err)) } }) }
Beautiful!!
Can be made a little more elegant at the cost of a little performance like this:
const isDense = arr => arr.length === Object.keys(arr).length // ... if (isDense(values)) { resolve(values) }
That way we can get rid of the resolvedCount variable.
resolvedCount
But I think @darkwiiplayer 's second solution is by far the most elegant 😉
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Bugfixed version:
Spoiler
We write directly to indexes in the array, instead of
push
ing, and keep track of the resolved count in a separate variable.Beautiful!!
Can be made a little more elegant at the cost of a little performance like this:
That way we can get rid of the
resolvedCount
variable.But I think @darkwiiplayer 's second solution is by far the most elegant 😉