Another way to be proactive is to architect the solution before you code with a stakeholder. Write up a doc with a proposal, talk about the solution with the approvers, update the ticket. Giving people a heads up goes a long way to preventing out of context replies or strange control issues and may prevent having to redo the work. Putting the doc in a knowledge base that isn’t a pull request would be preferable I would think.
As a reviewer, I’m a bit of a perfectionist but have given up being nitpicky. I wish others would do the same. It’s extremely annoying when code reviews are subjective. I try to be as objective as possible.
Most importantly, disarm everyone with kindness!
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
Thanks for posting! This is good advice.
Another way to be proactive is to architect the solution before you code with a stakeholder. Write up a doc with a proposal, talk about the solution with the approvers, update the ticket. Giving people a heads up goes a long way to preventing out of context replies or strange control issues and may prevent having to redo the work. Putting the doc in a knowledge base that isn’t a pull request would be preferable I would think.
As a reviewer, I’m a bit of a perfectionist but have given up being nitpicky. I wish others would do the same. It’s extremely annoying when code reviews are subjective. I try to be as objective as possible.
Most importantly, disarm everyone with kindness!