DEV Community

Tuan Thanh Tan
Tuan Thanh Tan

Posted on

My second accepted PR for hacktoberfest

Hello every, my name is Dustin. I'd like to talk about my experience of solving another issue on github that are labelled as hacktoberfest 2021.

Reasons

The reason behind why I chose this project was because I'd love to do something with React to refresh my knowledge of React and learn more about it

Second pull request

My second pull request was also simple and easy enough in terms of coding and understanding the code. I have used React for quite a long time so I know how it would be structured and where to find what I'm looking for.

The project can be found here
My pull request can be found here

Detail

This issue does not depends much on other people's code mainly because this is a completely new component and a new route. My job was to create a 404 page that any undefined route will redirect to and add a route to the route file.

Code I added to route file

<Route path="/404">
  <NotFound />
</Route>

Redirect to="/404" />
Enter fullscreen mode Exit fullscreen mode

404 page

import { Container, Image } from "react-bootstrap";

import Dog from "../home/dog.jpg";

export default function NotFound() {
  return (
    <Container className="d-flex flex-column justify-center align-items-center">
      <Image src={Dog} rounded fluid />

      <h1>Page Not Found</h1>
    </Container>
  );
}
Enter fullscreen mode Exit fullscreen mode

Oldest comments (0)