DEV Community

Discussion on: How to write a PR that sparks joy

Collapse
 
w3ndo profile image
Patrick Wendo

So I followed this post. Write up a list of checks before I pushed my PR. Commented on the PR explaining choices I made.

And the results were staggering. My supervisor loved the PR. Constantly mentioned how it was really well done. I think this makes me think about my code a lot more in depth before making a PR. I spent a good 3 hours optimizing a query because I knew it could be better. It still wasn't the best, but it was certainly so much better.

This. This was my win this week. Finding this article has made me a very happy programmer.

Collapse
 
peterlunch profile image
Peter

Hey Patrick that's awesome to hear, it's one of the main reasons I write. Keep it up, eventually all these steps become automatic.