DEV Community

Discussion on: Forem Hacktoberfest: Let’s Internationalize!

Collapse
 
ben profile image
Ben Halpern

Here is a live PR example I just tossed up — different from what I walked through in the post. That is still up for grabs at the time of writing this.

Translate notification filters #14884

What type of PR is this? (check all applicable)

  • [ ] Refactor
  • [x] Feature
  • [ ] Bug Fix
  • [ ] Optimization
  • [ ] Documentation Update

Description

This follows existing patterns of internationalization to translate the filters on the notifications page.

The only added translation is "All".

The use of pluralization is following existing patterns. This may not be the most scalable as we broaden translations, but I think appropriate for now.

Related Tickets & Documents

dev.to/devteam/forem-hacktoberfest...

QA Instructions, Screenshots, Recordings

Screen Shot 2021-10-01 at 1 25 38 PM

Added/updated tests?

  • [ ] Yes
  • [x] No, and this is why: I think existing regression tests should suffice
  • [ ] I need help with writing tests