DEV Community

Discussion on: The Git Rebase Introduction I Wish I'd Had

Collapse
 
whitetire67 profile image
Paul Dailey • Edited

Love the drawings. The most confusing part when I was learning was the "rebase from" ... there are a lot of assumptions about this on other explanations.

One thing I never did that you have in your steps is the conflict resolution workflow. When I rebase and have conflicts, I never use commit as its not needed. Here is my workflow:

git rebase master
[ ... fix conflicts ]
git add [specifically what I need to add]
git rebase --continue

boom

Now I'm wondering if I've caused myself any issues by never using commit before I continue...

Collapse
 
maxwell_dev profile image
Max Antonucci

I'm actually not too sure about this myself. I think I've done a mix of conflict resolutions with and without that specific commit step, but the end result was basically the same. The one difference was I got an extra chance to rename the commit before continuing. I wrote it as resolving it like a normal merge conflict since in the Github documentation I read, that's how they emphasized it, so I borrowed their phrasing a bit.

I don't believe it's a cause for any serious concerns though. If anyone else can clarify this though please share! I did some research here too but couldn't get many clear answers.