Our way: Let the code breath

👉 Go to Summary

There is no wrong or right way, there is our way.

-- Someone

.
.
.

Separate contexts

WTF!?

$post = Helper::sanitize($post);
$post = Helper::validation($post);
$post->notify($user);
$comments = Helper::crazy('hello');
$comments->gosh();

Nice!

$post = Helper::sanitize($post);
$post = Helper::validation($post);
$post->notify($user);

$comments = Helper::crazy('hello');
$comments->gosh();

.
.
.

Please, line breaks!

WTF!?

$hello = 'Mary';
if(...) {

}
foreach(...) {

}
if(...) {

}
$go = 'Paul';

Nice!

$hello = 'Mary'; 
// <---here
if (...) {

}

foreach(...) {

}

if(...) {

}
// <---here
$go = 'Paul';

.
.
.

Cleaner IF

WTF!?

if (User::where('name', 'Joe')->first() && 
   Product::where('name', 'xbox')->count() == 0) {
   throw new Exception("I'm sorry Joe. We don't have Xbox");
}

Nice!

$isJoe = User::where('name', 'Joe')->first();
$hasXbox = Product::where('name', 'xbox')->count() == 0;

if ($isJoe && ! $hasXbox) {
   throw new Exception("I'm sorry Joe. We don't have Xbox");
}

.
.
.

Early return

WTF!?

// You can buy a toy ONLY:
//  - If you have money 
//  - If it is weekend
//  - If it is NOT snowing

if($haveMoney) {
   if(! $isWeekend) {
       throw new Exception("It is not weekend!")
   } else {
      if($isSnowing) {
          throw new Exception("It is snowing!")
      } else {
          return 'Yes! I can buy!';
      }
   }
} else {
   throw new Exception("I don't have money!")
}

// Oh my... who did this!?

Nice!

// No need to read rules, I can read the code.

if (! $haveMoney) {
   throw new Exception("I don't have money!")   
}

if (! $isWeekend) {
    throw new Exception("It is not weekend!")
}

if ($isSnowing) {
    throw new Exception("It is snowing!")
} 

return 'Yes! I can buy!';