-
How did you go about doing your code reviews? Do you prefer an async or sync approach? Why?
At this point that I prefer async approach.
Not everyone loves to go by sync way, especially some of us do have own business to work on and may not have good time to match our partner and to work at the same time. -
What was it like testing and reviewing someone else's code? Did you run into any problems? Did anything surprise you?
I felt I could learn something from other's code and I could improve my knowledge by reviewing someone else's code at that time.
I did have problem that I have to figure someone else's code out and to check where the problem is, this processing was hard.
I surprised that maybe some mistakes I had and someone else did have too. -
What was it like having someone test and review your code? Were you surprised by anything?
I have had experiences where my intern and colleagues would review my code every time I pushed it to GitHub, from my ex-colleagues to my partner in OSD600.
However, I was still surprised that some things I thought were okay actually were not, and I missed many issues. For example, there were things I was used to doing as an intern, but now I have to be aware that my role has changed. Therefore, I need to give clear instructions to ensure everyone understands them before following my directions, so they can easily achieve the results I want. -
What kind of issues came up in your testing and review? Discuss a few of them in detail.
There are some instructions were not clear enough to understand how to do. Like, the command line was not clear.
Some features did not satisfy the requirements that even I tried many times but it was not working properly when I used the command line. -
Provide links to issues you filed, and summarize what you found?
https://github.com/whyang9701/repopal/issues/3
https://github.com/whyang9701/repopal/issues/5
I found that we thought some features were satisfy the requirements but actually they were not, and some of them that I had too. -
Provide links to issues that were filed on your repo, and what they were about?
https://github.com/slyang08/repo-snapshot/issues/1
https://github.com/slyang08/repo-snapshot/issues/3
https://github.com/slyang08/repo-snapshot/issues/4
They are about licensing, authorship, and one of the different tool managers I used, which were not clear to some people who did not understand them well. -
Were you able to fix all your issues? What was that like?
I was able to fix all of them successfully by filling in some fields and making the instructions easy for people to understand.
I fixed the CLI tool that had no path and made it able to report everything in the project. -
What did you learn through the process of doing the testing and reviewing?
I learned how to test different styles of CLI tools. I also learned that even though the CLIs are similar, their syntax is different from mine.
For further actions, you may consider blocking this person and/or reporting abuse
Top comments (0)