DEV Community

loading...

Discussion on: Towards zero bugs

Collapse
akatrevorjay profile image
Trevor Joynson

You made a logic error in your code:

if (hidden) { show(); } else { hide(); }.

I think you meant the opposite.

Also software that is decently complex will always have bugs. Don't get me wrong, you get better at identifying common causalities over time as you have shown here, but given sufficient complexity, you will eventually have bugs. It's just entropy at work.

Collapse
conw_y profile image
Jonathan Author

Thanks for pointing out the error! I've fixed the bug.

Collapse
qm3ster profile image
Mihail Malo

Hewwo, pwease change

- if (hidden) { show(); } else { hide(); }
+ if (hidden) { hide(); } else { show(); }`.

if hidden is the current state.
OR, if hidden is desired state, change

- if (!hidden) { show(); } else { hide(); }
+ if (!hidden) { hide(); } else { show(); }

You didn't flip the cases when negating the predicate.

Stylistically I would ofc prefer one of:

if (hidden) show()
else hide()

or

hidden ? show() : hide()

for a better signal/noise ratio (which makes bugs more evident)

Thread Thread
conw_y profile image
Jonathan Author

Apologies for the delay. I've fixed the logic error you rightly pointed out.