loading...

re: I made over 1,000 code reviews - this is what I learned VIEW POST

FULL DISCUSSION
 

Sit with the author to review the code

from my point of view, you should do this only when you have question to PR or if it is quite big, otherwise it is just waste of time.

you will have a faster feedback loop which can help you both grow.

i don't see how 'sitting with author to review code' it can help both grow.

I ran this code locally

this looks really great

 

I completely agree that if a MR od straight forward, there is actually no need to sit together. Will update to make it explicit.

For the growth effect, it's more relevant to learn how to better communicate, teach and take real-life criticism.

 

Sit with the author to review the code

Voice feedbacks is always great :) But of course, as mentioned the PR should be "important" (yeah, it's relative... But if the PR only changes a very small thing it's not necessary).

I'd also add something to improve the conversation: I always read the PR before (maybe two times) & try to understand briefly, if I can't I write a question. In brief, I prepare the meeting.

I had a tech-lead that didn't read any PR before the sit, and so he was reading the code along with me. It was such a pain and a wast of time... That's why I use this process for me to review PR :)

code of conduct - report abuse