DEV Community

Discussion on: My opinion on what makes a good Code Review.

Collapse
 
deathwaiting profile image
ahmed galal

Java developer, My reviewer usually points outs me over complicating things like:

  • using too much streams
  • using too much var keyword
  • using records
  • using Stream.toUnmodifibleSet() unnecessaryly
  • using a class for representing Money (Currency + Bigdecimal) instead of just using BigDecimal

Is that what they mean by KISS 😅?

Collapse
 
vikbert profile image
Xun Zhou

if you got the comments such as "using a class for representing Money" several times, it might be a good idea to talk about it in another dev-jourfix or retro meeting. The goal is to clarify if your team can do a design decision together, if we apply an ValueObject Money instead of using BigDecimal generally. If yes, just put such thing into your team coding convention. Then everything will be easier in the future.