My answer after reading the title: sure, short-circuiting is a handy tool sometimes.
My answer after reading that snippet: dear god kill it with fire.
I think short-circuiting is fine as long as it is still performing a normal boolean operation -- they should never be used to run arbitrary code.
I would avoid anything more complicated than something like
boolean fileIsValid = file.exists() && !file.isEmpty()
Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink.
Hide child comments as well
Confirm
For further actions, you may consider blocking this person and/or reporting abuse
We're a place where coders share, stay up-to-date and grow their careers.
My answer after reading the title: sure, short-circuiting is a handy tool sometimes.
My answer after reading that snippet: dear god kill it with fire.
I think short-circuiting is fine as long as it is still performing a normal boolean operation -- they should never be used to run arbitrary code.
I would avoid anything more complicated than something like