DEV Community

Discussion on: Mistakes I made in code reviews and what I do now

Collapse
 
galdin profile image
Galdin Raphael

One thing I always do when I think a piece of code could be better, is ask why they did it the way they. Or type what I had in mind and ask them what they think about it.

Reviews as discussions feel more welcoming, than reviews where someone is "correcting" you.

Collapse
 
wivani_ profile image
Wim VN

Exactly how I have been approaching code reviews for quite a while and the team happily follows this format. It's a conversation where you hope that there's learning involved. And it might as well be the reviewer who learns, even if he is in any form senior to the one who wrote the code.
I also try to throw in 'well done' remarks, to avoid it becomes a conversation only about the things that are so-so or are in need of a discussion.