re: Improve Your Code Reviews: The "No BS" Guide to Being a Dev with a BFA VIEW POST

FULL DISCUSSION
 

I agree with all of the above. I would only add that sometimes it is ok to add a comment to a PR and still allow the code to be merged (and, with it, allow folks to learn by delivering).

I don't know about you guys, but when I know managers are breathing at the poor dev's neck, it is hard for me to stop a PR because of something like using a slightly less optimal method. I just leave a comment so the dev can apply it in future PRs.

code of conduct - report abuse