re: Improve Your Code Reviews: The "No BS" Guide to Being a Dev with a BFA VIEW POST

FULL DISCUSSION
 

Great post! I am always the reviewed one and I agree with everything you said.

And I want to add up that the process of opening a PR requires attention as well, making a good description of what you've done (not only the code, but the reason behind it) makes it a lot easier for the reviewer to understand the context and to avoid a few questions like "Why did you choose blue" (not sure if it is the best example here, but I hope you understand what I mean).

 

That's a really good point – just throwing code out into the ether and going "okay, now review it" puts all the work on the reviewer. If you can provide those guiding comments, you're a lot more likely to get your code approved quickly haha

code of conduct - report abuse