DEV Community

Discussion on: Managing rxjs subscriptions with takeUntil()

Collapse
 
j3nnning profile image
Jenning Ho • Edited

this.onDestroy.unsubcribe() is unecessary since it is only used in takeUntil.

takeUntil have an internal unsubscribe.

there's also no need to do a .complete() call like some does.
a single .next() is enough
you can read more about it here

twitter.com/Michael_Hladky/status/...
twitter.com/kreuzercode/status/123...