DEV Community

Discussion on: J.A.R.V.I.S is now READY!

Collapse
 
j_mplourde profile image
Jean-Michel Plourde

in jarvis.py:65 there's you gmail credentials in plaintext. I really recommend moving that to your env variables and to change you gmail password.

Also it doesn't seem to use AI, but just if else, am I wrong?

Collapse
 
gauravsingh9356 profile image
Gaurav Singh

Yes, you are right, for conversation stuff I used it but all others like a dictionary, weather report, location, searching, email sending are dynamic and are fetched

Collapse
 
advyth profile image
Advyth Ashok

Hey, the creds are still exposed in your commit history.

Thread Thread
 
gauravsingh9356 profile image
Gaurav Singh

Yeah, now all cleared
Thanks