DEV Community

Discussion on: A pull request is submitted, what next?

Collapse
 
japhethobala profile image
Japheth Obala

I agree with most of the points you have made.

To add on to the list,

One of the challenges with code reviews is really, written communication.
You might want to make a point but it comes out very rude or malicious, because of the tone.

How this can be over come is by asking the W questions.

What is happening here? Are you ... If you are, this is the challenge.

Where is this used ? or Where is this defined.

When is this initialized, or when is this called?

How will this affect ...?

Very informative article.

Collapse
 
cyberomin profile image
Celestine Omin

Yeah, you're absolutely right. Which is why I stressed on the fact that an extra care should be put when crafting those comments. Thanks for reading.