DEV Community

loading...

Discussion on: 6 Things to Avoid When Contributing to Open-Source Projects

Collapse
jessica000 profile image
Jessica Valencia

Nice post!
I have some questions though.

1. I think this kind of PR is perfectly OK

Fixes bug #543

If I can't open PR like this one, then what else can I open? (other than typo fix and trivial fix)

2. What is commit squashing?

Collapse
_garybell profile image
Gary Bell

In relation to #1, the "fixes bug #543" part was one of 3 messages in the example PR. By itself it's fine. When added with the other 2 at the same time, it makes things difficult.

Commit squashing makes multiple commits which form part of the PR (so allowing you to work incrementally and commit often) show as only 1 commit on the receiving branch. It helps keep things tidy and concise.