Full stack web dev.
Studying FP web development approaches, while helping Mission Bit create paths to programming for underserved public school kids.
Previously @ Gradescope.
"I really like the effort you put into this bla bla bla, it might be my impression but this could be done differently, and i would have probably have written this"
I'd distinguish between the "like the effort" bit and the "might be my impression" bit -- the former is harmless but the latter waters down your stance. And ideally, there'd be some mention of why the proposed alternative is better.
But I agree with your larger point. It's nice when people get the point. Belle parole non pascon i gatti...
that can make the code review less "demotivating"
I actually really enjoy seeing what I've missed, even if I might feel dumb later. It's like seeing a magic trick get revealed. But I've seen folks dread code review who were nevertheless very good devs. Everyone's politeness meter is calibrated differently, I guess.
Trouble maker and Problem solver ⚙️🔧
Loves simplicity, hates bullshit 💩.
Productivity obsessed, avid learner 🖥🚀
Sport and outdoor freak 🧗⛰
Metalhead 🎸🤘 Father of 2 👨👩👦👦
Opinions are my own
Full stack web dev.
Studying FP web development approaches, while helping Mission Bit create paths to programming for underserved public school kids.
Previously @ Gradescope.
I'd distinguish between the "like the effort" bit and the "might be my impression" bit -- the former is harmless but the latter waters down your stance. And ideally, there'd be some mention of why the proposed alternative is better.
But I agree with your larger point. It's nice when people get the point. Belle parole non pascon i gatti...
I actually really enjoy seeing what I've missed, even if I might feel dumb later. It's like seeing a magic trick get revealed. But I've seen folks dread code review who were nevertheless very good devs. Everyone's politeness meter is calibrated differently, I guess.
despite being italian i never heard that (it's probably regional :-) very very nice!
lol. my father's from Avellino province but no one in my family says it either. I saw it online and it seemed cute and half-relevant :P